[PATCH] D151309: [RISCV][NFC] Simplify decoding code of disassembler

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 20:16:56 PDT 2023

pcwang-thead added a comment.

In D151309#4370636 <https://reviews.llvm.org/D151309#4370636>, @craig.topper wrote:

> The order we search these tables doesn't make sense. Shouldn't we be checking the standard table first, then falling back to vendor tables after that? Even with a vendor extension enabled, the majority of the instructions are going to be standard so we should decode them first.

I didn't change the order, it is the same. Does the order really matter? The vendor extensions must not conflict with standard encoding space.
But from the perspective of compile time, I think the order may matter because for most instructions they can exit the decoding early.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list