[PATCH] D151273: [llvm-debuginfod] Switch cl to OptTable

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 15:13:05 PDT 2023


mysterymath accepted this revision.
mysterymath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-debuginfod/llvm-debuginfod.cpp:81-85
+    if (!llvm::to_integer(V, Value, 0)) {
+      errs() << A->getSpelling() +
+                    ": expected a non-negative integer, but got '" + V + "'";
+      exit(1);
+    }
----------------
This should actually check that the integer is nonnegative, and the name should reflect this (NonNegInt?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151273/new/

https://reviews.llvm.org/D151273



More information about the llvm-commits mailing list