[PATCH] D151227: RFC: LiveIntervalCalc: Always split separate components

Wed May 24 13:20:28 PDT 2023

foad abandoned this revision.
foad added a comment.

In D151227#4369508 <https://reviews.llvm.org/D151227#4369508>, @arsenm wrote:

> The MIR is a standalone thing with rules on its own independent of the LiveIntervals. LiveIntervals is supposed to be a reflection of the MIR, it doesn't make sense to have restrictions on the MIR because of LiveIntervals. The implication there is some MIR which exists that's valid under -O0 but not with LiveIntervals suggests brokenness

A slightly different way of looking at the current situation: MIR *does* have rules forbidding multiple disconnected definitions, but MachineVerifier currently does not enforce them unless it has access to LiveIntervals.

In any case I removed the offending test as part of D129208 <https://reviews.llvm.org/D129208>, so I'm not planning to pursue this patch. Feel free to pick it up if you want.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151227/new/

https://reviews.llvm.org/D151227