[PATCH] D151353: [DebugInfo] Add error-handling to DWARFAbbreviationDeclarationSet
Alex Langford via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 12:31:17 PDT 2023
bulbazord added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:304
+ if (!Abbrev)
+ return NumErrors;
+
----------------
fdeazeve wrote:
> fdeazeve wrote:
> > I am a bit confused by this: isn't NumErrors always 0 here?
> Oh nvm, I see that the previous code was already doing the same
I can move the declaration down and return 0 directly here. That might make it less confusing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151353/new/
https://reviews.llvm.org/D151353
More information about the llvm-commits
mailing list