[PATCH] D151353: [DebugInfo] Add error-handling to DWARFAbbreviationDeclarationSet

Felipe de Azevedo Piovezan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 12:10:05 PDT 2023


fdeazeve added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:304
+  if (!Abbrev)
+    return NumErrors;
+
----------------
I am a bit confused by this: isn't NumErrors always 0 here?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:312
+  if (!AbbrDecls)
+    return NumErrors;
+
----------------
Same questions about NumErrors here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151353/new/

https://reviews.llvm.org/D151353



More information about the llvm-commits mailing list