[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

Wed May 24 10:53:03 PDT 2023

craig.topper added a comment.

In D150670#4367736 <https://reviews.llvm.org/D150670#4367736>, @pmatos wrote:

> In D150670#4352094 <https://reviews.llvm.org/D150670#4352094>, @craig.topper wrote:
>
>>> Preventing the simplification means adding target specific code in instcombine which seems even worse than adding it here given as @dschuff 
>>> pointed out, there's precedent with x86.
>>
>> How harmful is it to avoid breaking rotate patterns even if the target doesn't support rotate?
>
> Hi Craig, I thought initially your question was for Nikita but it's apparently for me. I am sorry but I am not sure I understand your question. Could you please rephrase?

My question was equivalent to @nikic 's option 1.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150670/new/

https://reviews.llvm.org/D150670