[PATCH] D151241: [AMDGPUCodegenPrepare] Add NewPM Support

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 09:50:18 PDT 2023


aeubanks accepted this revision.
aeubanks added a comment.

lgtm (I didn't verify that the pass actually doesn't make CFG changes)



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:1883
 
-      if (Next != E) { // Control flow changed
-        BasicBlock *NextInstBB = Next->getParent();
-        if (NextInstBB != BB) {
-          BB = NextInstBB;
-          E = BB->end();
-          FE = F.end();
-        }
-      }
-    }
+  PreservedAnalyses PA;
+  if (Impl.run(F)) {
----------------
put this in the if block


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:1888-1890
+  return PreservedAnalyses::all();
 
 }
----------------
extraneous empty line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151241/new/

https://reviews.llvm.org/D151241



More information about the llvm-commits mailing list