[PATCH] D150990: [split-file] Add flags to support comments and adding extension to output files

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 08:56:41 PDT 2023


MaskRay added a comment.

Thanks for the reply. The motivation looks good!

> Those two features allow us to integrate split-file notation and C++ DR tests notation:
> // dr164: 16 becomes //--- dr164: 16, which produces dr164.cpp file with the corresponding test.
> I go into more details on motivation in Discourse thread.

I think this paragraph can be made clearer without being overly verbose:

We will change some tests under `clang/test/CXX/drs` to use `//--- dr164: 16` instead of `// dr164`.
With `--add-file-extension=.cpp --allow-comments`, split-file will create a file named `dr164.cpp` instead of `dr164: 16`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150990/new/

https://reviews.llvm.org/D150990



More information about the llvm-commits mailing list