[PATCH] D150963: [AArch64] merge scaled and unscaled zero narrow stores.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Could you make sure that we have tests where the first offset is > the second offset and with negative offsets?



================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:760
+  int64_t OffsetImm;
+  // Calculate final offset in bytes
+  if (IOffsetInBytes > MIOffsetInBytes)
----------------
nit: This doesn't calculate the final offset, only selects the offset


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:766
+
+  // Adjust final offset if the result opcode is a scaled store.
+  int NewOpcode = getMatchingWideOpcode(Opc);
----------------
the code below doesn't adjust the final offset any longer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150963/new/

https://reviews.llvm.org/D150963