[PATCH] D151326: [Assignment Tracking] Ignore stores to a negative offset from an alloca
J. Ryan Stinnett via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 06:48:16 PDT 2023
jryans added a comment.
In D151326#4368298 <https://reviews.llvm.org/D151326#4368298>, @Orlando wrote:
> In D151326#4368227 <https://reviews.llvm.org/D151326#4368227>, @jryans wrote:
>
>> What would happen with a positive-but-still-out-of-bounds offset here?
>
> Good question. Those assignments are tracked, for better or for worse. e.g. we get a DBG_VALUE describing that out of bounds offset covering a fragment of the variable which is also out of bounds. I can see the argument for not tracking them. I don't //think// actively tracking them causes any issues though. Possibly we might see a location list rather than a single location if one of these out-of-bounds locations had been DSE'd. I think it is worth looking into further. I'll add it to my list as a low priority task (due to the apparent "harmless" nature of it), if you're happy with that?
Thanks for the initial thoughts on this. It would be good to investigate eventually, but I agree it's fine to consider that low priority future work.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151326/new/
https://reviews.llvm.org/D151326
More information about the llvm-commits
mailing list