[PATCH] D151221: [RISCV] Scalarize constant stores of fixed vectors up to 32 bits

[Luke Lau via Phabricator via llvm-commits]

luke marked 3 inline comments as done.
luke added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll:66
 
 define void @buildvec_vid_step2_add0_v4i8(ptr %z0, ptr %z1, ptr %z2, ptr %z3) {
+; RV32-LABEL: buildvec_vid_step2_add0_v4i8:
----------------
reames wrote:
> I think you're loosing the spirit of the test on these.  This looks to be intended to exercise materialization of the vector constant, not the store of that constant to memory.  Can you adjust the test to keep the prior codegen or something close to it?
> 
> You can return the values from individual tests, or use volatile stores.
Volatile stores still get scalarized so I've just returned the values in the cases that were affected


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151221/new/

https://reviews.llvm.org/D151221