[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 03:29:30 PDT 2023


dmgreen added a comment.

In D127115#4367640 <https://reviews.llvm.org/D127115#4367640>, @foad wrote:

> FYI I ran this patch on an internal corpus of AMDGPU graphics shaders and didn't see anything alarming. There was a slight change in the way fmul+fadd are combined into fma, but I don't think it was consistently worse - just different. Anyway I will work on that, but I do not think it should block this patch.

The tests I ran also looked fine. Nothing looked worrying in what I tried.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list