[PATCH] D150681: [SCEVExpander] Remember phi nodes inserted by LCSSA construction

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 01:12:02 PDT 2023


fhahn added a comment.

In D150681#4367280 <https://reviews.llvm.org/D150681#4367280>, @nikic wrote:

> @fhahn Maybe it would be better to drop the IRBuilder argument and insert all phis into the vector? You added it in https://github.com/llvm/llvm-project/commit/a9b06a2c14f9a38ba16165f0343faaa9ae713fec specifically for the SCEVExpander use case, but as it is not sufficient, it might make sense to drop it again in this patch.

Sounds good to me, thanks for looking into this!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150681/new/

https://reviews.llvm.org/D150681



More information about the llvm-commits mailing list