[PATCH] D151276: Weaken MFI Max Call Frame Size Assertion

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 19:55:50 PDT 2023

barannikov88 added a comment.

I'm not sure this is the correct fix. The assertion specifically checks that MaxCallFrameSize and AdjustsStack computed here are the same as computed by `MachineFrameInfo::computeMaxCallFrameSize`.
Have you been able to figure out why the results of the calculations are different?

Comment at: llvm/test/CodeGen/AArch64/compute-call-frame-size-unreachable-pass.ll:1
+; RUN: llc < %s
oskarwirga wrote:
> barannikov88 wrote:
> > barannikov88 wrote:
> > > The test without -mtriple will run for the default target (LLVM_DEFAULT_TARGET_TRIPLE). Does it trigger on any backend?
> > > If so, can it be moved to llvm/test/CodeGen/Generic?
> > > 
> > Ah, never mind, it contains the triple string.
> > It is a bit of unusual though, llc test don't usually have neither triple nor datalayout.
> > 
> I don't know what is usual when it comes to this stuff, happy to change things to make it proper :)
llc tests usually have -mtriple argument instead of specifying 'target triple' in the source and usually don't have 'target datalayout' (it is inferred from the triple).
This allows you to write multiple RUN lines with different -mtriple's, i.e. makes tests more flexible.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list