[PATCH] D143463: [X86] Use the CFA when appropriate for better variable locations around calls.

[Kyle Huey via Phabricator via llvm-commits]

khuey added a comment.

In D143463#4364427 <https://reviews.llvm.org/D143463#4364427>, @jmorse wrote:

> Just to confirm my understanding, this should have no interaction with the shrink-wrapping optimisation pass because there shouldn't be any stack-stored variables before frame setup occurs, yes?

I'm not familiar with how that optimization works I don't think it will matter at all since it just changes how the frame base is computed by the debugger. Assuming there are tests for that optimization, they passed on the earlier version of this patch that made the change unconditionally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143463/new/

https://reviews.llvm.org/D143463