[PATCH] D148836: [X86] Use "l" prefix for data sections under medium/large code model

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks marked 2 inline comments as done.
aeubanks added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:653
   } else {
-    Name = getSectionPrefixForGlobal(Kind);
+    bool IsLarge = false;
+    if (isa<GlobalVariable>(GO))
----------------
MaskRay wrote:
> Use `bool IsLarge = ... && ...` or avoid the used-once variable.
the reason for this and the other style choices is that D149288 (which I'll submit alongside this patch) will expand upon these


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148836/new/

https://reviews.llvm.org/D148836