[PATCH] D151246: [InstCombine] Improve bitreverse optimization

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 13:43:36 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1723-1727
+    if (Instruction *crossLogicOpFold =
+            foldBitOrderCrossLogicOp<Intrinsic::bitreverse>(IIOperand,
+		                                                        Builder)) {
+      return crossLogicOpFold;
+    }
----------------
nit: Omit braces for single-line if.

It also looks like some tab indentation snuck in here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151246/new/

https://reviews.llvm.org/D151246



More information about the llvm-commits mailing list