[PATCH] D149345: [Utils] Added the ability to print the pass number and IR after it is triggered

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

lg with the one comment addressed



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:772
+  if (shouldPrintPassNumbers())
+    dbgs() << " Running pass " << CurrentPassNumber << " " << PassID << "\n";
+
----------------
dbakunevich wrote:
> aeubanks wrote:
> > aeubanks wrote:
> > > extra space?
> > ditto for the one in printAfterPass, but actually shouldn't this go in printBeforePass?
> No, this logic should be near with PrintAtPassNumber.
I definitely think
```
  ++CurrentPassNumber;

  if (shouldPrintPassNumbers())
    dbgs() << "Running pass " << CurrentPassNumber << " " << PassID << "\n";
```
should be in printBeforePass, there's no reason to duplicate it between the two printAfterPasses (e.g. the extra space wasn't updated in the copy above)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149345/new/

https://reviews.llvm.org/D149345