[PATCH] D150899: [PowerPC] Add DFP compare instructions.

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:40
+
+let isCompare = 1, mayRaiseFPException = 1 in {
+  def DCMPU : XForm_17<59, 642, (outs crrc:$BF), (ins f8rc:$RA, f8rc:$RB),
----------------
amyk wrote:
> I noticed some other compare instructions set `hasSideEffects` to 0 accordingly, but I was wondering if we need to do that here?
Actually, I seem to have missed a few flags here and not just that one. I'll add the flags for this now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150899/new/

https://reviews.llvm.org/D150899