[PATCH] D151187: [doc] Add casting style preference to coding standards

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 11:42:22 PDT 2023


mehdi_amini added a comment.

> Someone would have to test over a large corpus of code to see what the false positive vs true positive rate looks like. My intuition is that it would have too many false positives to be enabled by default, so it wouldn't meet the bar for a clang diagnostic.

Don't we have many clang-diagnostics that aren't enabled by default? I thought that was a given that people can opt-in specific warnings in this category.
What if we got LLVM entirely clean for such a warning: would it be good enough signal that it can be useful?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151187/new/

https://reviews.llvm.org/D151187



More information about the llvm-commits mailing list