[PATCH] D150464: [FuncSpec] Improve the accuracy of the cost model.

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 08:51:37 PDT 2023


labrinea added inline comments.


================
Comment at: llvm/unittests/Transforms/IPO/FunctionSpecializationTest.cpp:1
+//===- FunctionSpecializationTest.cpp - Cost model unit tests -------------===//
+//
----------------
I've spotted a problem. This unittest is relying on target specific costs, so it will fail on some targets. I need to either make it x86 specific or change the expected values based on some logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150464/new/

https://reviews.llvm.org/D150464



More information about the llvm-commits mailing list