[PATCH] D151221: [RISCV] Scalarize constant stores of fixed vectors up to 32 bits

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 08:24:50 PDT 2023


luke added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-int-buildvec.ll:134-142
+; RV32-NEXT:    lui a4, 1040368
+; RV32-NEXT:    addi a4, a4, -256
+; RV32-NEXT:    sw a4, 0(a0)
+; RV32-NEXT:    sw a4, 0(a1)
+; RV32-NEXT:    lui a0, 1040352
+; RV32-NEXT:    sw a0, 0(a2)
+; RV32-NEXT:    lui a0, 1036288
----------------
luke wrote:
> I'm wondering if we should detect constants that are sequences (`BuildVectorSDNode::isConstantSequence`) to prevent this.
Gating on if its a sequence seems to make it worse as only some of the stores end up getting scalarized, whilst some of them are kept as vectors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151221/new/

https://reviews.llvm.org/D151221



More information about the llvm-commits mailing list