[PATCH] D149711: [PowerPC] Remove asserts from the disassembler.

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 08:06:52 PDT 2023


stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp:351
   unsigned Zeros = llvm::countr_zero(Imm);
   assert(Zeros < 8 && "Invalid CR bit value");
 
----------------
nemanjai wrote:
> nemanjai wrote:
> > While we're at it, we can turn this one into a disassembly failure rather than an assert.
> Did you just miss this one or is there a reason you didn't address this comment?
Sorry, I did miss this one. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149711/new/

https://reviews.llvm.org/D149711



More information about the llvm-commits mailing list