[PATCH] D151170: [StandardInstrumentations] Add option to dump IR to a file on crash

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser requested changes to this revision.
jamieschmeiser added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:2228
     PassInstrumentationCallbacks &PIC) {
-  if (!PrintCrashIR || CrashReporter)
+  if (!PrintOnCrash && PrintOnCrashPath.empty())
     return;
----------------
You have removed the test on CrashReporter, which prevents multiple reporters.  Now, a subsequent one will replace previous reporters.  Is this intentional?  I think the replaced ones will still be registered with the signal handler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151170/new/

https://reviews.llvm.org/D151170