[llvm] 846bde4 - Silence switch statement contains 'default' but no 'case' labels warning; NFC

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 06:28:58 PDT 2023


Author: Aaron Ballman
Date: 2023-05-23T09:28:05-04:00
New Revision: 846bde483d63b2abbb8dd45ceba2dab538446432

URL: https://github.com/llvm/llvm-project/commit/846bde483d63b2abbb8dd45ceba2dab538446432
DIFF: https://github.com/llvm/llvm-project/commit/846bde483d63b2abbb8dd45ceba2dab538446432.diff

LOG: Silence switch statement contains 'default' but no 'case' labels warning; NFC

These are showing up in MSVC builds.

Added: 
    

Modified: 
    llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h
    llvm/lib/ExecutionEngine/JITLink/ppc64.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h b/llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h
index 699e656eb38ea..bb9f5f158ff09 100644
--- a/llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h
+++ b/llvm/include/llvm/ExecutionEngine/JITLink/ppc64.h
@@ -29,14 +29,9 @@ const char *getEdgeKindName(Edge::Kind K);
 /// TOOD: Add fixups as we add edges.
 inline Error applyFixup(LinkGraph &G, Block &B, const Edge &E,
                         const Symbol *GOTSymbol) {
-  switch (E.getKind()) {
-  default:
-    return make_error<JITLinkError>(
-        "In graph " + G.getName() + ", section " + B.getSection().getName() +
-        " unsupported edge kind " + getEdgeKindName(E.getKind()));
-  }
-
-  return Error::success();
+  return make_error<JITLinkError>(
+      "In graph " + G.getName() + ", section " + B.getSection().getName() +
+      " unsupported edge kind " + getEdgeKindName(E.getKind()));
 }
 
 } // end namespace llvm::jitlink::ppc64

diff  --git a/llvm/lib/ExecutionEngine/JITLink/ppc64.cpp b/llvm/lib/ExecutionEngine/JITLink/ppc64.cpp
index ca862b0f89cee..d138b0a6f8aee 100644
--- a/llvm/lib/ExecutionEngine/JITLink/ppc64.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/ppc64.cpp
@@ -18,10 +18,7 @@ namespace llvm::jitlink::ppc64 {
 
 const char *getEdgeKindName(Edge::Kind K) {
   // TODO: Add edge names.
-  switch (K) {
-  default:
-    return getGenericEdgeKindName(static_cast<Edge::Kind>(K));
-  }
+  return getGenericEdgeKindName(static_cast<Edge::Kind>(K));
 }
 
 } // end namespace llvm::jitlink::ppc64


        


More information about the llvm-commits mailing list