[PATCH] D151163: ValueTracking: Ignore -0 for nsz sqrt with UseInstrInfo in computeKnownFPClass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 03:44:19 PDT 2023


arsenm added a comment.

In D151163#4363911 <https://reviews.llvm.org/D151163#4363911>, @foad wrote:

> Looks OK but shouldn't the nsz flag be applied more generally to the result of every computeKnownFPClass call?



In D151163#4363911 <https://reviews.llvm.org/D151163#4363911>, @foad wrote:

> Looks OK but shouldn't the nsz flag be applied more generally to the result of every computeKnownFPClass call?

No because of nsz’s bizarre definition. It doesn’t mean no -0 appears, it means you don’t care about the sign of zero.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151163/new/

https://reviews.llvm.org/D151163



More information about the llvm-commits mailing list