[PATCH] D148957: [AMDGPU] Add intrinsic for converting global pointers to resources

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:8686
+          DAG.getNode(ISD::SHL, Loc, MVT::i32, ExtStride,
+                      DAG.getShiftAmountConstant(16, MVT::i32, Loc));
+    }
----------------
Hardcoding this to an i32 constant is fine instead of going through DAG.getShiftAmountConstant


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:8693-8694
+                             NewHighHalf, NumRecords, Flags);
+  SDValue RsrcPtr = DAG.getNode(ISD::BITCAST, Loc, MVT::i128, Rsrc);
+  return RsrcPtr;
+}
----------------
can fold to direct return 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148957/new/

https://reviews.llvm.org/D148957