[PATCH] D150768: [SVE ACLE] Canonicalise SVE merging intrinsics

mgabka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 01:55:17 PDT 2023


mgabka added a comment.

This patch for now covers only fadd/fadd_u, fsub/fsub_u and fmul/fmul_u, what about other intrinsics which are having both merging and _u variants I thought we want to replace all merging forms with _u forms when the predicate is all true  ? @paulwalker-arm what is your opinion here?



================
Comment at: llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-fmul_u-idempotency.ll:3
+
+target triple = "aarch64-unknown-linux-gnu"
+
----------------
the test in this file do not match the description of the commit message, I think that is an optimization we want to cover separately, @paulwalker-arm wjhat is your opinion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150768/new/

https://reviews.llvm.org/D150768



More information about the llvm-commits mailing list