[PATCH] D149428: [BBUtils][NFC] Delete SplitBlockAndInsertIfThen with DT.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 01:38:26 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks fine to me.

I have a slight preference for landing this in two stages, first convert all users and then delete the old method, but I won't insist.



================
Comment at: llvm/lib/Transforms/Utils/LibCallsShrinkWrap.cpp:504
-// Verify the dominator after we've updated it locally.
-  assert(!DT || DT->verify(DominatorTree::VerificationLevel::Fast));
-  return Changed;
----------------
What's the reason for removing this extra verification?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149428/new/

https://reviews.llvm.org/D149428



More information about the llvm-commits mailing list