[PATCH] D151188: [lld] Find resource and lib dir

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I didn't have a look at the contents of the file yet, but wanted to add a reference here:

In D151188#4363560 <https://reviews.llvm.org/D151188#4363560>, @thieta wrote:

> - The way lld finds libraries seems to happen very early, so unless the user specifies /machine:x64, the libraries won't be seen because we haven't parsed any object files and extracted the target machine yet. One thought I had here was to try to find the libraries early, and if we don't see a library, we can wait until we have parsed an object file, extracted the machine, and then tried to refind those libraries we failed to find. But I wanted to make sure that this is the path we want to take.

I believe this is closely related to what D150981 <https://reviews.llvm.org/D150981> does too - please have a look at that if it helps something here.



================
Comment at: llvm/include/llvm/WindowsDriver/LLVMPaths.h:26
+
+#endif
----------------
Missing newline at the end of the file


================
Comment at: llvm/lib/WindowsDriver/LLVMPaths.cpp:109
+
+} // namespace llvm
----------------
Missing newline at the end of the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151188/new/

https://reviews.llvm.org/D151188