[PATCH] D150782: [NFC][Py Reformat] Reformat python files in mlir subdir

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 01:00:40 PDT 2023


ftynse added a comment.

> I am more concerned about divergence within the project than a one time diff here (it'll be easier to benefit from a pre-merge linter, have a unified doc and workflow for contributors, etc), and it is true that historically the LLVM project has been discouraging mass-fixes like this one, but MLIR has been more aggressive with this kind of mass clang-tidy / clang-format fixes as well.

I'm on the same page regarding long-term divergence here and personally not opposed to the change, just want to make everyone is aware of the change.

> Let's be more practical: looking at the diff, do you see regressions in readability / maintainability with the new format @ftynse ?

I prefer two-space over four-space indentation given how bad Python is with line splitting, but this is nitpicking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150782/new/

https://reviews.llvm.org/D150782



More information about the llvm-commits mailing list