[PATCH] D141188: [MergeICmps] Adapt to non-eq comparisons

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 21:14:48 PDT 2023


Allen added a comment.

In D141188#4343111 <https://reviews.llvm.org/D141188#4343111>, @bgraur wrote:

> @Allen this last patch is causing a miscompile again.
>
> Here's a small artificial repro:
>
>   namespace {
>   struct Dt {
>     Dt() = default;
>   };
>   
>   At this revision the program returns '1' (incorrect), at the previous revision the program returns '0' (as expected).
>   
>   Could you please revert?

I think the above case is fixed with last update, so I'll retry after rebase if nobody object it. sorry for the miscompile.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141188/new/

https://reviews.llvm.org/D141188



More information about the llvm-commits mailing list