[PATCH] D143739: [WinEH] Ignore dynamic allocas of catch objects

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 19:59:00 PDT 2023


rnk added a comment.

In D143739#4363058 <https://reviews.llvm.org/D143739#4363058>, @Naville wrote:

> I'm not sure if I understand the fix issue correctly, given my very limited knowledge with WinEH. But wouldn't this result in a silent failure if DynAlloca is used?

That's true, but it's consistent with passing other non-alloca values to the catchpad. The next best thing would be to provide a diagnostic in the verifier here, but it depends on knowledge of the personality function:
https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L4261


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143739/new/

https://reviews.llvm.org/D143739



More information about the llvm-commits mailing list