[PATCH] D150929: [RISCV][BF16] Enable __bf16 for riscv targets

Mon May 22 19:02:29 PDT 2023

joshua-arch1 added a comment.

In D150929#4361151 <https://reviews.llvm.org/D150929#4361151>, @asb wrote:

> I feel (IMHO) this is jumping to the endpoint a bit - the usual route for something like this is:
>
> - MC layer support
> - LLVM codegen support (and tests!)
> - Any needed Clang support
>
> I was hoping to push out some patches related to zfbfmin tests+codegen today but might time-out (if so, I'll return to it tomorrow).
>
> I think the tentative conclusion of https://discourse.llvm.org/t/rfc-c-23-p1467r9-extended-floating-point-types-and-standard-names/70033 is to make __bf16_t an arithmetic type on all targets - I'd recommend keeping an eye on https://reviews.llvm.org/D150913 (and ideally helping to review it), as that's bound to interact with this patch.

Hi, I have already basically implemented the codegen part and is going to post for review today.

================
Comment at: clang/test/Sema/vector-decl-crash.c:1
-// RUN: %clang_cc1 %s -fsyntax-only -verify -triple riscv64-unknown-unknown
+// RUN: %clang_cc1 %s -fsyntax-only -verify -triple powerpc64le-unknown-unknown

----------------
kito-cheng wrote:
> What??? we should just remove this testcase IF we really support __bf16 IMO.
Actually, I didn't want to change riscv64 into another target. However, I see someone directly changed x86 into riscv64 when he supported __bf16.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150929/new/

https://reviews.llvm.org/D150929