[PATCH] D147899: [ValueTracking] Add tests for using condition in select for non-zero analysis; NFC

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/test/Analysis/ValueTracking/select-known-non-zero.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
+
----------------
nikic wrote:
> Is this file still supposed to be here? Some of the tests are redundant with those in the other file, such as the first one (select_v_ne_z), or basically anything that shows a diff in D147900.
These are the original tests before using `cmpExcludesZero` (when the analysis used knownbits). Would like to add them as well as they are cases we should be able to handle. I'll drop all the tests that have diff in current D147900 or match the const test though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147899/new/

https://reviews.llvm.org/D147899