[PATCH] D150390: [AMDGPU] Introduce and use the new PRED_COPY opcode

Mon May 22 13:29:37 PDT 2023

arsenm added a comment.

In D150390#4361458 <https://reviews.llvm.org/D150390#4361458>, @yassingh wrote:

> We could merge WWM code insertion logic with SIFixVGPRCopies while still lowering PRED_COPY back to COPY there(to prevent duplication of COPY lowering logic)? That would avoid running a separate pass. Or are you suggesting another approach altogether to handle PRED_COPY instructions?

No, I'm saying there's no case where PRED_COPY->COPY makes sense. PRED_COPY needs to be lowered differently from COPY. In this scheme we aren't speculatively spamming PRED_COPY on SGPR copies which later need to be simplified. There's no simplification to be performed, only lowering

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150390/new/

https://reviews.llvm.org/D150390