[PATCH] D118118: [SDAG] Preserve unpredictable metadata, teach X86CmovConversion to respect this metadata

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:115
+                             // this instruction.
+    Unpredictable = 1 << 16, // Instruction is unpredictable.
   };
----------------
I kind of think this description is overly short. Unpredictable for an instruction could mean many things.


================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:124
   MachineOperand *Operands = nullptr;   // Pointer to the first operand.
-  uint16_t NumOperands = 0;             // Number of operands on instruction.
-
-  uint16_t Flags = 0;                   // Various bits of additional
+  unsigned Flags = 0;                   // Various bits of additional
                                         // information about machine
----------------
Use uint32_t since we've very carefully counted bits in all of the fields.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118118/new/

https://reviews.llvm.org/D118118