[PATCH] D151103: [RISCV] Scalarize small fixed vector copies < XLEN

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Personally, I find the structure required to share the code more confusing than helpful.  Having to trace the NewV creation through really confuses the code.  I'd prefer we just add a separate rule with it's own conditions.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:12201
+        //   vse16.v    v8, (a1)
+        // TODO: Handle loads with multiple uses
+        else if (auto *L = dyn_cast<LoadSDNode>(Val);
----------------
Remove the todo, we'll probably never implement that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151103/new/

https://reviews.llvm.org/D151103