[PATCH] D151116: [AMDGPU][GlobalISel] Update legalization condition for G_BITCAST

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:700
-    // Don't worry about the size constraint.
-    .legalIf(all(isRegisterType(0), isRegisterType(1)))
     .lower();
----------------
You're essentially recreating a less refined version of isRegisterType, but we need the refinements. We can't purely decide this based on the raw bit sizes like this class check does, since we don't want to see something like <64 x i1> as legal. You should either filter out the cases without a corresponding class in isRegisterType or just finally round out the set of classes to cover every possible tuple 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151116/new/

https://reviews.llvm.org/D151116