[PATCH] D74977: [RISCV][GlobalISel] Add lowerFormalArguments for calling convention

[Nitin John Raj via Phabricator via llvm-commits]

nitinjohnraj added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/irtranslator/args.ll:257
+  ret void
+}
----------------
arsenm wrote:
> Probably should have some byval, sret, and cases where the argument list runs out of registers. Same for return values / hidden sret
> Probably should have some byval, sret, 
Correct me if I'm wrong, but byval and sret both require support for aggregate types, which this patch doesn't support. 

> sret, and cases where the argument list runs out of registers.
Do you have an example of a similar test? I wasn't aware that we could run out of registers at this phase, I thought that we could have an unlimited number of virtual registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74977/new/

https://reviews.llvm.org/D74977