[PATCH] D150878: Add StringRef::consumeInteger(APInt)

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 08:54:52 PDT 2023


thopre added a comment.

In D150878#4361073 <https://reviews.llvm.org/D150878#4361073>, @thopre wrote:

> Remove <64 bit APInt consumeInteger tests

These did not make sense, the whole point of consumeInteger(APInt) is to not be limited in bitsize and thus succeed. That's why unit tests were failing: they were expecting a consumeInteger failing when the expected value is bigger than 32bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150878/new/

https://reviews.llvm.org/D150878



More information about the llvm-commits mailing list