[PATCH] D151105: [AMDGPU] Fix lowering of @llvm.amdgcn.set.inactive(imm, poison)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:1546
+                                *MRI, MI->getOperand(0)));
+    MI->setDesc(TII->get(CopyOp));
   }
----------------
foad wrote:
> arsenm wrote:
> > If this is to use a v_mov_b32 it will be left without the implicit exec 
> No, the V_SET_INACTIVE has an implicit exec use, and we don't remove it.
Leaving copy with exec is also weird, and we're totally inconsistent on whether that's required and where 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151105/new/

https://reviews.llvm.org/D151105