[PATCH] D151089: [Remarks] Add option to retain all remarks during remark linking.

[Florian Hahn via Phabricator via llvm-commits]

fhahn created this revision.
fhahn added reviewers: thegameg, anemet, JDevlieghere.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
fhahn requested review of this revision.
Herald added a project: LLVM.

At the moment, dsymutil drops all remarks without debug location.

There are many cases where debug location may be missing for remarks,
mostly due LLVM not preserving debug locations. When using bitstream
remarks for statistical analysis, those missed remarks mean we get an
incomplete picture.

The new remarks-keep-all flag can be used to retain all remarks during
linking.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151089

Files:
  llvm/include/llvm/Remarks/RemarkLinker.h
  llvm/lib/Remarks/RemarkLinker.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
  llvm/tools/dsymutil/LinkUtils.h
  llvm/tools/dsymutil/Options.td
  llvm/tools/dsymutil/dsymutil.cpp
  llvm/unittests/Remarks/RemarksLinkingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151089.524266.patch
Type: text/x-patch
Size: 6469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230522/ce4152f1/attachment.bin>