[PATCH] D150684: [LoopReroll] Remove unused LoopReroll pass

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 02:13:56 PDT 2023

nikic added a comment.

In D150684#4350080 <https://reviews.llvm.org/D150684#4350080>, @fhahn wrote:

> In D150684#4347035 <https://reviews.llvm.org/D150684#4347035>, @efriedma wrote:
>> My team has been using this pass in production for a while. I think we have a few internal bugfixes that never made it upstream, though.  If there's interest, I'll get someone on my team to push those fixes.
>> Granted, the current state of the pass this might not pass codereview standards even with those fixes...
> I think if there's a concrete plan to fix the open issues at least, then we could keep it. But otherwise the code can be always be brought back .

Yeah, this is the main bit I care about. To keep the pass upstream, there should also be an upstream owner for it, who at least makes sure the correctness issues get fixed. If fixes only get applied downstream, then it's probably better for the whole pass to live downstream.



More information about the llvm-commits mailing list