[PATCH] D150900: [InstCombine] Insert a bitcast to enable merging similar store insts

Anshil Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 21 14:08:35 PDT 2023


gandhi21299 updated this revision to Diff 524129.
gandhi21299 marked 2 inline comments as done.
gandhi21299 added a comment.

- Simplified OtherStoreIsMergeable as requested

The reason for another iteration of instcombine for @inttoptr_merge(..) is that mergeStoreIntoSuccessor() generates a case where a store/load pair is merged into an inttoptr which is later merged with the PHI inserted by mergeStoreIntoSuccessor() in the first iteration. I am not sure if implementing these cases in mergeStoreIntoSuccessor() is viable since it will make the code redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150900/new/

https://reviews.llvm.org/D150900

Files:
  llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
  llvm/test/Transforms/InstCombine/AMDGPU/merging-stores-into-successor.ll
  llvm/test/Transforms/InstCombine/merging-multiple-stores-into-successor.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150900.524129.patch
Type: text/x-patch
Size: 11224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230521/e90f7bb6/attachment.bin>


More information about the llvm-commits mailing list