[PATCH] D150900: [InstCombine] Insert a bitcast to enable merging similar store insts

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

This basically looks good to me, but I'll have to check what is going on with instcombine-infinite-loop-threshold here.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:1619-1620
+      return false;
+    if (SI.isSameOperationAs(OtherStore))
+      return true;
+
----------------
Can drop this check -- it's a subset of the one below.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:1624-1627
+    if (!CastInst::isBitOrNoopPointerCastable(OSVTy, SIVTy, DL) ||
+        !SI.hasSameSpecialState(OtherStore))
+      return false;
+    return true;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150900/new/

https://reviews.llvm.org/D150900