[PATCH] D150641: [bazel] Refactor entries in WORKSPACE to bzl files

Aaron Siddhartha Mondal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 15:08:42 PDT 2023


aaronmondal added a comment.

Ok tested this, works. This needs some adjustment after https://github.com/llvm/llvm-project/commit/a268127736e4d703cef8c9f4841f9a8e8ac21ba7 (the zlib-ng archive needs to be a `non-bcr-deps.bzl`-dep, the old zlib variant is vulnerable and causes a gazillion warnings), but I like the way that this cleans up the bzlmod patch.

I'm actually stongly in favor of completely removing support for terminfo before we make this change though. Terminfo removal has been overdue for years and since we've now reworked all other external dependencies we might as well kick out all remaining legacy. That way we make this change a bit more compact and the bzlmod patch will also really nicely fall into place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150641/new/

https://reviews.llvm.org/D150641



More information about the llvm-commits mailing list