[PATCH] D150641: [bazel] Refactor entries in WORKSPACE to bzl files

[Matt via Phabricator via llvm-commits]

matts1 added a comment.

> Blocking until I've tested this against rules_ll. It's a noop for the workspace build but might have implications for our already existing module build.

It won't have any implications, given that in your module build you won't actually import any of the things I added.

> Did something change regarding maybe in bzlmod? I'm fairly certain that maybe won't be compatible with bzlmod (https://github.com/bazelbuild/bazel/issues/15377).

I believe what wyv meant when he said it "doesn't work with bzlmod" is that if you import the same repo rule twice, it won't do what it's supposed to and stop the second repo rule invocation. This is a non-issue for modules though, since as he mentioned, namespacing prevents this from ever happening, unless you do it twice in the same module (which you shouldn't, and we don't).

> Potentially related, the bzlmod patch: (https://reviews.llvm.org/D137008)

Ah, I wasn't aware of this, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150641/new/

https://reviews.llvm.org/D150641