[PATCH] D150922: [KnownBits] Return `0` for poison {s,u}div inputs

Fri May 19 08:08:32 PDT 2023

goldstein.w.n added inline comments.

================
Comment at: llvm/test/CodeGen/WebAssembly/pr59626.ll:18
+; CHECK-32-NEXT:    i32.store8 2
+; CHECK-32-NEXT:    local.get 1
 ; CHECK-32-NEXT:    local.get 0
----------------
luke wrote:
> goldstein.w.n wrote:
> > I think this is a meaningless regression. The IR being tests evaluates to just  `ret i8 poison` @luke is this okay?
> Can you point to the IR test that's evaluating to just poison? As long as this test case isn't crashing then I'm ok, but I'm probably not the right person to ask about KnownBits. I'm surprised this is the only test case that is affected!
> Can you point to the IR test that's evaluating to just poison? 
This test `@f`:
https://alive2.llvm.org/ce/z/VDJkEb

> As long as this test case isn't crashing then I'm ok, but I'm probably not the right person to ask about KnownBits. I'm surprised this is the only test case that is affected!

I'm just asking if the affects to the wasm codegen is okay.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150922/new/

https://reviews.llvm.org/D150922