[PATCH] D150922: [KnownBits] Return `0` for poison {s,u}div inputs

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 04:34:24 PDT 2023


luke added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/pr59626.ll:18
+; CHECK-32-NEXT:    i32.store8 2
+; CHECK-32-NEXT:    local.get 1
 ; CHECK-32-NEXT:    local.get 0
----------------
goldstein.w.n wrote:
> I think this is a meaningless regression. The IR being tests evaluates to just  `ret i8 poison` @luke is this okay?
Can you point to the IR test that's evaluating to just poison? As long as this test case isn't crashing then I'm ok, but I'm probably not the right person to ask about KnownBits. I'm surprised this is the only test case that is affected!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150922/new/

https://reviews.llvm.org/D150922



More information about the llvm-commits mailing list